#795 Fix staging CI#796
Open
NoelDeMartin wants to merge 3 commits into
Open
Conversation
Prompts: - Implement a bash script here that clones the SolidOS/solid-logic repo from github, runs its build scripts, and uses npm to install it as a local depdency to solid-ui - Default to using the same branch name as the one were the CI is running, using the GITHUB_BASE_REF env variable AI work summary: - Introduced a new script `setup-ci.sh` to clone, build, and link the solid-logic repository as a peer dependency for CI. - Updated the CI workflow to run the setup script after installing npm dependencies. Co-Authored-By: Cursor <cursoragent@cursor.com>
Contributor
|
That's cool, it does get a bit more complicated though like solid-panes for instance it depends on all the panes. I wonder if it would get to be a bit much in that case. |
Member
Author
The script shouldn't get over-complicated, it would just take a list of dependencies rather than assume that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues we have in CI as described in #795.
The fix clones the
solid-logicdependency, and installs it locally before running the rest of the CI. This only works withsolid-logicnow, but this script could be refactored to take a list of dependencies that should be symlinked this way. Also, we could potentially use the same script in other repositories in the organization in order to run their respective CIs.Overall, this is a working solution but it isn't ideal. Even though the CI works, developers will still need to manage their own local dependencies. Maybe this isn't too much of a problem, given that the expected development workflow is to use the Lerna config from the
solidosrepository.If we want to improve this in the future, I can only think of two solutions: